Summary: | IDL files use #if defined(ENABLE_whatever) instead of #if ENABLE_whatever | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Mentovai <mark> | ||||||
Component: | Platform | Assignee: | Mark Mentovai <mark> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mark Mentovai
2008-10-03 11:48:26 PDT
Followup: the IDL files should use #if ENABLE_WHATEVER directly, because they are preprocessed without wtf/Platform.h being included, and the ENABLE() macro is not available. Created attachment 24064 [details]
grep -r ^#if.\*ENABLE_ .
I tested this out in a regular WebKit Mac build, and it seems to do what's expected of it.
Comment on attachment 24064 [details]
grep -r ^#if.\*ENABLE_ .
Change is fine but please add a description and bug url to the changelog.
Created attachment 24120 [details]
grep -r ^#if.\*ENABLE .
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/objc/DOMEvents.h M WebCore/bindings/objc/PublicDOMInterfaces.h M WebCore/dom/Document.idl M WebCore/page/DOMWindow.idl M WebCore/svg/svgtags.in Committed r37362 |