Bug 213345

Summary: Unify Bitmap math loops in MarkedBlock::Handle::specializedSweep().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: REOPENED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 215312    
Bug Blocks:    
Attachments:
Description Flags
proposed patch.
none
proposed patch.
saam: review+
patch for landing. none

Mark Lam
Reported 2020-06-18 11:40:23 PDT
Also address feedback from Robin and Saam in https://bugs.webkit.org/show_bug.cgi?id=213071.
Attachments
proposed patch. (28.21 KB, patch)
2020-06-18 12:10 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (28.10 KB, patch)
2020-06-18 12:19 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
patch for landing. (29.20 KB, patch)
2020-06-18 19:14 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-06-18 12:10:40 PDT
Created attachment 402224 [details] proposed patch.
Mark Lam
Comment 2 2020-06-18 12:19:08 PDT
Created attachment 402225 [details] proposed patch.
Mark Lam
Comment 3 2020-06-18 12:27:05 PDT
Comment on attachment 402225 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review > Source/JavaScriptCore/ChangeLog:11 > + understand than then old code. /then/the/ > Source/JavaScriptCore/ChangeLog:38 > + 5. Aldo fixed some typos in comments. /Aldo/Also/
Robin Morisset
Comment 4 2020-06-18 12:41:15 PDT
Comment on attachment 402225 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review r=me > Source/JavaScriptCore/heap/MarkedBlockInlines.h:345 > + if (emptyMode == NotEmpty) { This section is *much* more readable than before, thanks!
Saam Barati
Comment 5 2020-06-18 12:47:04 PDT
Comment on attachment 402225 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review > Source/JavaScriptCore/heap/MarkedBlockInlines.h:369 > + // At this point, a set bit in freeAtoms represents live cells. this is no longer true, right? Opposite
Saam Barati
Comment 6 2020-06-18 12:47:31 PDT
Comment on attachment 402225 [details] proposed patch. reinstating Robin's r+. I'm not done reviewing though
Saam Barati
Comment 7 2020-06-18 12:52:47 PDT
Comment on attachment 402225 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review > Source/JavaScriptCore/heap/MarkedBlockInlines.h:367 > + bool isEmpty = !anyBits; alternatively, you can just set this to false, then to true when iterating freeAtoms.forEachSetBit below
Saam Barati
Comment 8 2020-06-18 12:55:03 PDT
Comment on attachment 402225 [details] proposed patch. r=me too
Mark Lam
Comment 9 2020-06-18 13:07:54 PDT
Comment on attachment 402225 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=402225&action=review >> Source/JavaScriptCore/heap/MarkedBlockInlines.h:367 >> + bool isEmpty = !anyBits; > > alternatively, you can just set this to false, then to true when iterating freeAtoms.forEachSetBit below Good point. Thanks. >> Source/JavaScriptCore/heap/MarkedBlockInlines.h:369 >> + // At this point, a set bit in freeAtoms represents live cells. > > this is no longer true, right? Opposite Will fix.
Mark Lam
Comment 10 2020-06-18 19:14:17 PDT
Created attachment 402261 [details] patch for landing.
Mark Lam
Comment 11 2020-06-18 20:31:20 PDT
Thanks for the reviews. Landed in r263252: <http://trac.webkit.org/r263252>.
Radar WebKit Bug Importer
Comment 12 2020-06-18 20:32:17 PDT
<rdar://problem/64516410>
WebKit Commit Bot
Comment 13 2020-08-09 02:07:01 PDT
Re-opened since this is blocked by bug 215312
Note You need to log in before you can comment on or make changes to this bug.