Summary: | REGRESSION (r263098): [Win10] http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | youenn fablet <youennf> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, achristensen, cdumez, darin, ews-watchlist, japhet, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2020-06-17 09:54:04 PDT
Test history suggests that this regressed with https://trac.webkit.org/changeset/263098/webkit Youenn says he will look at this tomorrow. Marked tests as failing to keep EWS moving quickly in the interim. (In reply to Ryan Haddad from comment #4) > Marked tests as failing to keep EWS moving quickly in the interim. http://trac.webkit.org/r263162 Created attachment 402199 [details]
Patch
Test seem to pass in windows by reverting a change that was not mandatory for https://trac.webkit.org/changeset/263098/webkit. I am not quite sure why and we should probably get back to it at some point. Comment on attachment 402199 [details]
Patch
If this fixes it, I don't oppose. Definitely strange.
Committed r263218: <https://trac.webkit.org/changeset/263218> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402199 [details]. Comment on attachment 402199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402199&action=review > Source/WebCore/loader/ResourceLoaderOptions.h:145 > -enum class LoadedFromOpaqueSource : bool { > - No, > - Yes > +enum class LoadedFromOpaqueSource : uint8_t { > + Yes, > + No > }; If this value is sent cross process with Encoder/Decoder, changing from bool to uint8_t might require specializing EnumTraits. So it might be slightly trickier than just reverting. I see no test failures, I guess this is not done with this enumeration? (In reply to Alex Christensen from comment #8) > Comment on attachment 402199 [details] > Patch > > If this fixes it, I don't oppose. Definitely strange. This fixes it according the bots. > If this value is sent cross process with Encoder/Decoder, changing from bool > to uint8_t might require specializing EnumTraits. So it might be slightly > trickier than just reverting. I see no test failures, I guess this is not > done with this enumeration? Issue is WK1 and I do not think this is encoder/decoder. Maybe this is Windows compiler specific. |