Bug 213280

Summary: Web Inspector: Console: add comments for localized strings in execution context picker
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-06-16 18:47:54 PDT
.
Attachments
Patch (3.66 KB, patch)
2020-06-16 18:59 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-06-16 18:59:28 PDT
Created attachment 402070 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-06-16 19:18:13 PDT
<rdar://problem/64431737>
Joseph Pecoraro
Comment 3 2020-06-18 13:01:14 PDT
Comment on attachment 402070 [details] Patch r=me
Blaze Burg
Comment 4 2020-06-18 13:03:56 PDT
Comment on attachment 402070 [details] Patch rs=me We should clarify the style for localization disambiguation is to use '@'. I am more used to using '(explanation)', but all I seek is consistency.
EWS
Comment 5 2020-06-18 13:12:52 PDT
Committed r263225: <https://trac.webkit.org/changeset/263225> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402070 [details].
Note You need to log in before you can comment on or make changes to this bug.