| Summary: | Make invalidation of widgets more cross-platform | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
| Component: | Platform | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dave Hyatt
2008-10-02 23:40:56 PDT
Created attachment 24041 [details]
Patch
Comment on attachment 24041 [details]
Patch
Couple of nits.
+ ::InvalidateRect(m_popup, &r,false);
Missing space.
+/*
void Widget::invalidateRect(const IntRect& r)
Please remove this commented out code.
+ // Do windowless plugin invalidation.
+ invalidateWindowlessPluginRect(rect);
The comment doesn't really add anything here.
+ PluginWidget(NSView *view = 0)
+ : Widget(view)
The initializer list should be indented more.
+ [platformWidget() setNeedsDisplayInRect: rect];
Extra space.
- : Widget(view)
+ : PluginWidget(view)
Initialize list issue again.
r=me!
|