Bug 213259 – FileListCreator should only be used for resolving directories

• Component: Forms
• Status: RESOLVED FIXED

[Andy Estes]

FileListCreator should only be used for resolving directories

[Andy Estes]

rdar://problem/64375709

[Andy Estes]

Created attachment 402045 [details]
Patch

[Andy Estes]

Created attachment 402051 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 402051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402051&action=review

> Source/WebCore/html/FileInputType.cpp:427
> +    m_directoryFileListCreator = DirectoryFileListCreator::create([this, weakThis = makeWeakPtr(*this), icon = makeRefPtr(icon)](Ref<FileList>&& fileList) mutable {
> +        if (!weakThis)
>              return;
> -        setFiles(WTFMove(fileList), icon ? RequestIcon::Yes : RequestIcon::No);
> -        if (icon && !m_fileList->isEmpty() && element())
> -            iconLoaded(WTFMove(icon));
> -        m_fileListCreator = nullptr;
> +        didCreateFileList(WTFMove(fileList), WTFMove(icon));
>      });

Worth adding an ASSERT() that this runs on the main thread?  (Does not have to be addressed to land this since it wasn't present before.)

[Andy Estes]

Comment on attachment 402051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402051&action=review

>> Source/WebCore/html/FileInputType.cpp:427
>>      });
> 
> Worth adding an ASSERT() that this runs on the main thread?  (Does not have to be addressed to land this since it wasn't present before.)

👍

[Andy Estes]

Created attachment 402059 [details]
Patch

[EWS]

Committed r263129: <https://trac.webkit.org/changeset/263129>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402059 [details].