Bug 213243

Summary: O(n^2) behavior in media query resolution
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212757    
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2020-06-16 04:58:06 PDT
RuleSet::evaluteDynamicMediaQueryRules has complexity num(media queries) * num(style rules) for queries that flip value. This can become significant for pages that have 1000s of media queries.
Attachments
patch (4.16 KB, patch)
2020-06-16 05:10 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (4.00 KB, patch)
2020-06-16 05:53 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-06-16 05:01:43 PDT
<rdar://63997043>
Antti Koivisto
Comment 2 2020-06-16 05:10:05 PDT
Created attachment 401995 [details] patch
Antti Koivisto
Comment 3 2020-06-16 05:53:00 PDT
Created attachment 401997 [details] patch
EWS
Comment 4 2020-06-16 08:12:35 PDT
Committed r263092: <https://trac.webkit.org/changeset/263092> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401997 [details].
Note You need to log in before you can comment on or make changes to this bug.