Bug 213217

Summary: [iOS] Collecting screen properties in the UI process introduced a Safari launch time regression.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Description Per Arne Vollan 2020-06-15 14:54:24 PDT 
Calling collectScreenProperties() in WebProcessPool::platformInitializeWebProcess() introduced a Safari launch time regression on iOS.
Comment 1 Per Arne Vollan 2020-06-15 15:03:27 PDT 
rdar://problem/64374461
Comment 2 Per Arne Vollan 2020-06-15 15:04:29 PDT 
Created attachment 401943 [details]
Patch
Comment 3 Brent Fulgham 2020-06-15 16:01:33 PDT 
Comment on attachment 401943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401943&action=review

r=me

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=213217

<rdar://problem/64374461>

> Source/WebCore/ChangeLog:11
> +        the UI process.

It's a shame this code has to differ between macOS and iOS.
Comment 4 Per Arne Vollan 2020-06-15 16:05:33 PDT 
Created attachment 401952 [details]
Patch
Comment 5 Per Arne Vollan 2020-06-15 16:06:12 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 401943 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401943&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=213217
> 
> <rdar://problem/64374461>
> 

Fixed.

> > Source/WebCore/ChangeLog:11
> > +        the UI process.
> 
> It's a shame this code has to differ between macOS and iOS.

Thanks for reviewing!
Comment 6 EWS 2020-06-16 08:00:40 PDT 
Committed r263090: <https://trac.webkit.org/changeset/263090>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401952 [details].