Summary: | Consistently use WTF_ATTRIBUTE_PRINTF in Assertions.[cpp,h] | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | Web Template Framework | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2020-06-15 12:02:25 PDT
Created attachment 401919 [details]
Patch
Comment on attachment 401919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401919&action=review I didn’t set the commit queue flag yet because I’d like EWS to finish first. > Source/WTF/wtf/Assertions.cpp:175 > ALLOW_NONLITERAL_FORMAT_BEGIN I wonder if we still need this? Comment on attachment 401919 [details] Patch EWS are looking green.... (In reply to Darin Adler from comment #2) > > Source/WTF/wtf/Assertions.cpp:175 > > ALLOW_NONLITERAL_FORMAT_BEGIN > > I wonder if we still need this? I'll check. Guess: probably yes. (In reply to Michael Catanzaro from comment #3) > I'll check. Guess: probably yes. I was wrong, it doesn't seem to be needed with GCC 10, at least I don't see any new warnings. I can't vouch for other compilers, though. Committed r263062: <https://trac.webkit.org/changeset/263062> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401919 [details]. |