Bug 213157

Summary: [Mac Catalyst] Color inputs and selects fail to display popovers when clicked
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Wenson Hsieh 2020-06-12 17:06:49 PDT 
<rdar://problem/64004135>
Comment 1 Wenson Hsieh 2020-06-13 00:51:42 PDT 
Created attachment 401828 [details]
Patch
Comment 2 Tim Horton 2020-06-13 01:17:23 PDT 
Comment on attachment 401828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401828&action=review

> Source/WebKit/ChangeLog:9
> +        In Mac Catalyst, presenting popovers using `UIPopoverController` causes the first responder to change. This

Not totally clear why presenting a popover on iOS doesn't also cause the first responder to change, but ... OK?
Comment 3 Wenson Hsieh 2020-06-13 11:00:26 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 401828 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401828&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        In Mac Catalyst, presenting popovers using `UIPopoverController` causes the first responder to change. This
> 
> Not totally clear why presenting a popover on iOS doesn't also cause the
> first responder to change, but ... OK?

It looks like it's pretty much due to UIKit implementation details. On Mac Catalyst, _UIPopoverSceneManager is used to present popovers, which resigns first responder underneath -createPopoverSceneForContentViewController:sourceView:sourceRectInParentUIWindow:contentSize:permittedArrowDirections:showsArrow:userInterfaceStyle:withCompletionBlock:]. This codepath isn't taken on iOS and iPadOS.
Comment 4 EWS 2020-06-13 11:14:19 PDT 
Committed r263001: <https://trac.webkit.org/changeset/263001>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401828 [details].