| Summary: | Don't claim to support fullscreen mode unless fullScreenEnabled setting is enabled | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, rackler, sergio, tsavell, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Eric Carlson
2020-06-12 13:17:50 PDT
Created attachment 401791 [details]
Patch
Created attachment 401797 [details]
Patch for landing.
Created attachment 401800 [details]
Patch for landing
Created attachment 401908 [details]
Patch for landing
Created attachment 401917 [details]
Patch for landing
Created attachment 401948 [details]
Patch for landing
Created attachment 402034 [details]
Patch
Committed r263121: <https://trac.webkit.org/changeset/263121> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402034 [details]. It looks like the changes in this submit broke this test: media/video-fullscreen-only-playback.html Tracking this failure in: https://bugs.webkit.org/show_bug.cgi?id=213407 Reverted r263121 for reason: Broke media/video-fullscreen-only-playback.html on Catalina Debug Committed r263301: <https://trac.webkit.org/changeset/263301> Committed r263458: <https://trac.webkit.org/changeset/263458> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402034 [details]. |