Bug 213142

Summary: Don't claim to support fullscreen mode unless fullScreenEnabled setting is enabled
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, rackler, sergio, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing.
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch none

Eric Carlson
Reported 2020-06-12 13:17:50 PDT
Don't claim to support fullscreen mode unless fullScreenEnabled setting is enabled <rdar://problem/63753327>
Attachments
Patch (4.30 KB, patch)
2020-06-12 15:06 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (5.96 KB, patch)
2020-06-12 15:50 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.02 KB, patch)
2020-06-12 16:32 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.15 KB, patch)
2020-06-15 10:19 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.94 KB, patch)
2020-06-15 11:48 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.48 KB, patch)
2020-06-15 15:25 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (7.65 KB, patch)
2020-06-16 13:11 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2020-06-12 15:06:50 PDT
Created attachment 401791 [details] Patch
Eric Carlson
Comment 2 2020-06-12 15:50:04 PDT
Created attachment 401797 [details] Patch for landing.
Eric Carlson
Comment 3 2020-06-12 16:32:54 PDT
Created attachment 401800 [details] Patch for landing
Eric Carlson
Comment 4 2020-06-15 10:19:50 PDT
Created attachment 401908 [details] Patch for landing
Eric Carlson
Comment 5 2020-06-15 11:48:14 PDT
Created attachment 401917 [details] Patch for landing
Eric Carlson
Comment 6 2020-06-15 15:25:42 PDT
Created attachment 401948 [details] Patch for landing
Eric Carlson
Comment 7 2020-06-16 13:11:55 PDT
Created attachment 402034 [details] Patch
EWS
Comment 8 2020-06-16 15:41:23 PDT
Committed r263121: <https://trac.webkit.org/changeset/263121> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402034 [details].
Karl Rackler
Comment 9 2020-06-19 14:46:20 PDT
It looks like the changes in this submit broke this test: media/video-fullscreen-only-playback.html Tracking this failure in: https://bugs.webkit.org/show_bug.cgi?id=213407
Truitt Savell
Comment 10 2020-06-19 17:11:37 PDT
Reverted r263121 for reason: Broke media/video-fullscreen-only-playback.html on Catalina Debug Committed r263301: <https://trac.webkit.org/changeset/263301>
EWS
Comment 11 2020-06-24 08:55:03 PDT
Committed r263458: <https://trac.webkit.org/changeset/263458> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402034 [details].
Note You need to log in before you can comment on or make changes to this bug.