Bug 213072

Summary: Add dependencies for Migrate Headers and Generate Export Files build phases
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213067    
Attachments:
Description Flags
Uploading for reference; the work is incomplete -- still needs dependencies for Migrate Headers.
none
Patch none

Keith Rollin
Reported 2020-06-11 04:03:15 PDT
These build phases have incomplete specifications for the files they consume and produce, which can lead to incorrect builds.
Attachments
Uploading for reference; the work is incomplete -- still needs dependencies for Migrate Headers. (4.03 KB, patch)
2020-06-11 04:06 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (5.12 KB, patch)
2020-06-11 22:44 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-11 04:03:32 PDT
<rdar://problem/64249345>
Keith Rollin
Comment 2 2020-06-11 04:06:23 PDT
Created attachment 401631 [details] Uploading for reference; the work is incomplete -- still needs dependencies for Migrate Headers.
Keith Rollin
Comment 3 2020-06-11 22:44:33 PDT
Created attachment 401710 [details] Patch
Keith Rollin
Comment 4 2020-06-11 22:47:55 PDT
I tested this by performing full and then incremental NULL builds with XCBuild on and off. I then applied the patch from Bug 213067 and performed two incremental builds. I checked the build output of each build to verify that the desired build steps were being performed. Most importantly, the build failure discovered in Bug 213067 was gone.
Tim Horton
Comment 5 2020-06-11 23:18:44 PDT
Thanks, Keith!
EWS
Comment 6 2020-06-12 00:01:41 PDT
Committed r262935: <https://trac.webkit.org/changeset/262935> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401710 [details].
Note You need to log in before you can comment on or make changes to this bug.