Bug 212944

Summary: ComplexTextController: Use std::sort to calculate m_runIndices
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: TextAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212670    
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2020-06-08 18:05:34 PDT
ComplexTextController: Use std::sort to calculate m_runIndices
Attachments
Patch (3.51 KB, patch)
2020-06-08 18:24 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-06-08 18:24:19 PDT
Created attachment 401405 [details] Patch
Myles C. Maxfield
Comment 2 2020-06-09 12:13:05 PDT
Comment on attachment 401405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401405&action=review This is probably okay. One perhaps unintended consequence is that these values will no longer be computed lazily. However, most of the time, we iterate through the entire ComplexTextController, so the laziness doesn't buy us much in the common case. So I think this is fine. > Source/WebCore/platform/graphics/ComplexTextController.cpp:156 > + m_runIndices.uncheckedAppend(length - i - 1); This is kind of a neat idea. I like it.
EWS
Comment 3 2020-06-09 12:39:50 PDT
Committed r262803: <https://trac.webkit.org/changeset/262803> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401405 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-09 12:40:18 PDT
<rdar://problem/64175319>
Note You need to log in before you can comment on or make changes to this bug.