Bug 212942

Summary: WebKitLegacy: Exclude NSURLConnectionSPI.h from watchOS
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212718
https://bugs.webkit.org/show_bug.cgi?id=214004
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2020-06-08 17:16:45 PDT
NSURLConnectionSPI.h is not needed to build watchOS.
Attachments
Patch (1.39 KB, patch)
2020-06-08 17:21 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-08 17:17:22 PDT
<rdar://problem/64141877>
Jonathan Bedard
Comment 2 2020-06-08 17:21:30 PDT
Created attachment 401402 [details] Patch
EWS
Comment 3 2020-06-08 20:24:38 PDT
Committed r262764: <https://trac.webkit.org/changeset/262764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401402 [details].
Wenson Hsieh
Comment 4 2020-07-01 10:07:23 PDT
Comment on attachment 401402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review > Source/WebKitLegacy/mac/Misc/WebDownload.h:36 > +#import <pal/spi/cocoa/NSURLConnectionSPI.h> Hm...is it safe to import PAL headers like this? I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients...
Jonathan Bedard
Comment 5 2020-07-06 13:33:30 PDT
Comment on attachment 401402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review >> Source/WebKitLegacy/mac/Misc/WebDownload.h:36 >> +#import <pal/spi/cocoa/NSURLConnectionSPI.h> > > Hm...is it safe to import PAL headers like this? > > I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients... I think your right. Verifying locally right now that we don't need this, I think I just needed to change the define guard.
Note You need to log in before you can comment on or make changes to this bug.