Bug 212928

Summary: TextManipulation should only convert text from Node's text content to tokens
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: HTML EditingAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Sihui Liu
Reported 2020-06-08 15:32:16 PDT
...
Attachments
Patch (15.20 KB, patch)
2020-06-08 15:50 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (15.39 KB, patch)
2020-06-08 18:55 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.38 KB, patch)
2020-06-08 23:29 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-06-08 15:50:22 PDT
Created attachment 401386 [details] Patch
Sihui Liu
Comment 2 2020-06-08 18:55:22 PDT
Created attachment 401408 [details] Patch
Wenson Hsieh
Comment 3 2020-06-08 20:24:09 PDT
Comment on attachment 401408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401408&action=review > Source/WebCore/editing/TextManipulationController.cpp:234 > + if (contiansDelimiter) { Nit - contiansDelimiter => containsDelimiter > Source/WebCore/editing/TextManipulationController.cpp:329 > +TextManipulationController::ManipulationUnit TextManipulationController::createUnit(const Vector<String>& text, Node* textNode) Maybe make this take `Node& textNode`, since we never expect it to be null?
Sihui Liu
Comment 4 2020-06-08 23:29:56 PDT
Created attachment 401419 [details] Patch for landing
EWS
Comment 5 2020-06-08 23:54:25 PDT
Committed r262778: <https://trac.webkit.org/changeset/262778> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401419 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-08 23:55:16 PDT
<rdar://problem/64152411>
Note You need to log in before you can comment on or make changes to this bug.