Bug 212927

Summary: Removed unneeded POINTER_WIDTH macro from b3
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ysuzuki: review+, keith_miller: commit-queue-

Keith Miller
Reported 2020-06-08 15:17:51 PDT
Removed unneeded POINTER_WIDTH macro from b3
Attachments
Patch (2.00 KB, patch)
2020-06-08 15:19 PDT, Keith Miller 		ysuzuki: review+
keith_miller: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-06-08 15:19:08 PDT
Created attachment 401381 [details] Patch
Darin Adler
Comment 2 2020-06-08 15:42:00 PDT
Comment on attachment 401381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401381&action=review > Source/JavaScriptCore/b3/B3Width.h:46 > +constexpr inline Width pointerWidth() constexpr implies inline, so we never have to say both https://en.cppreference.com/w/cpp/language/constexpr
Keith Miller
Comment 3 2020-06-08 15:45:02 PDT
Comment on attachment 401381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401381&action=review >> Source/JavaScriptCore/b3/B3Width.h:46 >> +constexpr inline Width pointerWidth() > > constexpr implies inline, so we never have to say both > > https://en.cppreference.com/w/cpp/language/constexpr I was wondering if I needed both... I'll remove the inline.
Keith Miller
Comment 4 2020-06-08 15:46:25 PDT
Committed r262746: <https://trac.webkit.org/changeset/262746>
Radar WebKit Bug Importer
Comment 5 2020-06-08 15:47:23 PDT
<rdar://problem/64138322>
Note You need to log in before you can comment on or make changes to this bug.