Bug 212920

Summary:

[css-grid] Import some grid tests from WPT

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

Tools / Tests

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, ews-watchlist, jfernandez, obrufau, rego, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=1091944

Bug Depends on:

Bug Blocks:

209282

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Javier Fernandez

Reported 2020-06-08 14:09:51 PDT

We need to import a few tests from the WPT repository to cover some cases related to how baseline alignment may affect the grid's intrinsic size computation. These tests are needed to cover some of the changes to fix bug #209282

Attachments
Patch (46.08 KB, patch) 2020-06-08 15:23 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (67.88 KB, patch) 2020-06-09 01:59 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (49.34 KB, patch) 2020-06-09 03:00 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (49.34 KB, patch) 2020-06-09 03:38 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2020-06-08 14:11:42 PDT

These tests has been merged in the PR https://github.com/web-platform-tests/wpt/pull/24022

Javier Fernandez

Comment 2 2020-06-08 15:23:05 PDT

Created attachment 401382 [details] Patch

EWS Watchlist

Comment 3 2020-06-08 15:23:48 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Manuel Rego Casasnovas

Comment 4 2020-06-09 01:47:51 PDT

Comment on attachment 401382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401382&action=review > LayoutTests/TestExpectations:1070 > +webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001.html [ Failure ] I don't understand why you mark them as Failure. They have a -expected.txt file, so it won't need to be marked like that. And also the -expected file has all PASS.

Javier Fernandez

Comment 5 2020-06-09 01:59:32 PDT

Created attachment 401427 [details] Patch Change expectations to reflect the test cases failing

Manuel Rego Casasnovas

Comment 6 2020-06-09 02:07:47 PDT

Comment on attachment 401427 [details] Patch r=me, but the corresponding w3c-import.log file should be updated too.

Manuel Rego Casasnovas

Comment 7 2020-06-09 02:08:07 PDT

Also wait for green EWSs before landing.

Javier Fernandez

Comment 8 2020-06-09 03:00:05 PDT

Created attachment 401431 [details] Patch Tests pass on mac platform, so reflect that in the test expectations

Javier Fernandez

Comment 9 2020-06-09 03:38:47 PDT

Created attachment 401432 [details] Patch Fixed text expectations

Javier Fernandez

Comment 10 2020-06-09 04:57:25 PDT

Comment on attachment 401432 [details] Patch The failures in the mac-debug-wk1 seems unrelated to this change, so landing.

EWS

Comment 11 2020-06-09 05:11:18 PDT

Committed r262788: <https://trac.webkit.org/changeset/262788> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401432 [details].

Radar WebKit Bug Importer

Comment 12 2020-06-09 05:12:18 PDT

<rdar://problem/64160279>

Note You need to log in before you can comment on or make changes to this bug.