Bug 212905

Summary: [Flatpak][GStreamer] enhance GST_ environment variable passing
Product: WebKit Reporter: Víctor M. Jáquez L. <vjaquez>
Component: Tools / TestsAssignee: Víctor M. Jáquez L. <vjaquez>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Víctor M. Jáquez L.
Reported 2020-06-08 08:57:55 PDT
Particulary GST_DEBUG is passed twice, and the used one is quoted, which avoids the correct parsing in GStreamer.
Attachments
Patch (3.24 KB, patch)
2020-06-08 09:36 PDT, Víctor M. Jáquez L. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Víctor M. Jáquez L.
Comment 1 2020-06-08 09:36:51 PDT
Created attachment 401346 [details] Patch
Philippe Normand
Comment 2 2020-06-08 11:05:04 PDT
Comment on attachment 401346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401346&action=review > Tools/ChangeLog:10 > + quotes, but they break the parsing in GStreamer. Break what? GST_DEBUG="foo*:5" is expanded to something else?
Víctor M. Jáquez L.
Comment 3 2020-06-08 11:49:00 PDT
Comment on attachment 401346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401346&action=review >> Tools/ChangeLog:10 >> + quotes, but they break the parsing in GStreamer. > > Break what? GST_DEBUG="foo*:5" is expanded to something else? as if * were escaped and considered as a letter.
Philippe Normand
Comment 4 2020-06-09 01:24:04 PDT
env GST_DEBUG="webkit*:6" run-minibrowser --gtk LayoutTests/media/content/test.mp4 Works as expected here.
EWS
Comment 5 2020-06-09 01:34:00 PDT
Committed r262782: <https://trac.webkit.org/changeset/262782> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401346 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-09 01:34:15 PDT
<rdar://problem/64154995>
Radar WebKit Bug Importer
Comment 7 2020-06-09 01:34:16 PDT
<rdar://problem/64154996>
Note You need to log in before you can comment on or make changes to this bug.