Bug 212898 – [GTK] MiniBrowser: stop using GtkToolbar

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

It's no longer available in GTK4. Use a GtkBox with buttons instead.

[Carlos Garcia Campos]

Created attachment 401332 [details]
Patch

[Adrian Perez]

Comment on attachment 401332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401332&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:473
> +    return webkit_web_view_get_zoom_level(webView) != 1.0;

Comparing floating point numbers is usually a bad idea, due to rounding errors
and whatnot. Probably not much of an issue here, but the safest would be rounding
to the nearest integer and comparing that:

  return lrint(webkit_web_view_get_zoom_level(webView)) == 1;

No strong opinion, though. Feel free to leave the code as-is if you prefer.

[Carlos Garcia Campos]

(In reply to Adrian Perez from comment #2)
> Comment on attachment 401332 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401332&action=review
> 
> > Tools/MiniBrowser/gtk/BrowserWindow.c:473
> > +    return webkit_web_view_get_zoom_level(webView) != 1.0;
> 
> Comparing floating point numbers is usually a bad idea, due to rounding
> errors
> and whatnot. Probably not much of an issue here, but the safest would be
> rounding
> to the nearest integer and comparing that:
> 
>   return lrint(webkit_web_view_get_zoom_level(webView)) == 1;
> 
> No strong opinion, though. Feel free to leave the code as-is if you prefer.

I don't think it's a problem in this case because 1.0 is set when the load completes, which is what we want to check here.

[Carlos Garcia Campos]

Committed r262938: <https://trac.webkit.org/changeset/262938>