Bug 212888

Summary: Shrink __DATA by making more intended const things const for real.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: ASSIGNED    
Severity: Normal CC: bburg, benjamin, calvaris, cdumez, changseok, cmarcelo, dbarton, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, hi, jer.noble, jiewen_tan, joepeck, keith_miller, kondapallykalyan, mifenton, msaboff, pdr, philipj, saam, sergio, toyoshim, tzagallo, ysuzuki, yutak
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch.
none
proposed patch. none

Mark Lam
Reported 2020-06-07 20:53:40 PDT
...
Attachments
proposed patch. (44.25 KB, patch)
2020-06-07 21:14 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (45.14 KB, patch)
2020-06-07 21:35 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (59.51 KB, patch)
2020-06-08 08:04 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-06-07 21:14:30 PDT
Created attachment 401308 [details] proposed patch.
EWS Watchlist
Comment 2 2020-06-07 21:15:07 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Mark Lam
Comment 3 2020-06-07 21:35:01 PDT
Created attachment 401310 [details] proposed patch.
Mark Lam
Comment 4 2020-06-08 08:04:29 PDT
Created attachment 401339 [details] proposed patch.
Mark Lam
Comment 5 2020-06-08 08:46:48 PDT
It looks to me now like the WinEWS bot is running with stale code. The error message says: WebCore.lib(UnifiedSource-84c9f43f-3.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::CSS::CSSProperty::Priority" (__imp_?Priority@CSSProperty@CSS@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(UnifiedSource-84c9f43f-3.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::CSS::CSSProperty::ParsedOk" (__imp_?ParsedOk@CSSProperty@CSS@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(UnifiedSource-84c9f43f-3.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::CSS::CSSProperty::Status" (__imp_?Status@CSSProperty@CSS@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] WebCore.lib(UnifiedSource-84c9f43f-6.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * const Inspector::Protocol::Network::Response::MimeType" (__imp_?MimeType@Response@Network@Protocol@Inspector@@2PEBDEB) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\bin64\WebKit.dll : fatal error LNK1120: 4 unresolved externals [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(810,5): error MSB6006: "link.exe" exited with code 1120. [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj] However, we don't even generate any line of code with "static char const * const Inspector::Protocol::CSS::CSSProperty::Priority" in it anymore.
Mark Lam
Comment 6 2020-06-08 09:55:52 PDT
Comment on attachment 401339 [details] proposed patch. Taking out of review for now. The size test results actually showed a regression contrary to my expectation. This needs more investigation.
Note You need to log in before you can comment on or make changes to this bug.