Bug 212869

Summary: [LFC] Add support for width: min/max-content
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2020-06-06 09:11:31 PDT
ssia
Attachments
Patch (20.96 KB, patch)
2020-06-06 09:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (21.06 KB, patch)
2020-06-06 09:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (21.31 KB, patch)
2020-06-06 10:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-06-06 09:37:05 PDT
Created attachment 401263 [details] Patch
Antti Koivisto
Comment 2 2020-06-06 09:39:28 PDT
Comment on attachment 401263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401263&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:107 > + auto width = widthType == WidthType::Normal ? style.logicalWidth() : widthType == WidthType::Min ? style.logicalMinWidth() : style.logicalMaxWidth(); a lambda might be more readable
Antti Koivisto
Comment 3 2020-06-06 09:41:04 PDT
Comment on attachment 401263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401263&action=review >> Source/WebCore/layout/FormattingContextGeometry.cpp:107 >> + auto width = widthType == WidthType::Normal ? style.logicalWidth() : widthType == WidthType::Min ? style.logicalMinWidth() : style.logicalMaxWidth(); > > a lambda might be more readable with a switch
zalan
Comment 4 2020-06-06 09:55:21 PDT
Created attachment 401265 [details] Patch
zalan
Comment 5 2020-06-06 10:12:11 PDT
Created attachment 401267 [details] Patch
EWS
Comment 6 2020-06-06 11:02:13 PDT
Committed r262690: <https://trac.webkit.org/changeset/262690> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401267 [details].
Radar WebKit Bug Importer
Comment 7 2020-06-06 11:03:21 PDT
<rdar://problem/64071478>
Sam Weinig
Comment 8 2020-06-06 16:19:45 PDT
Comment on attachment 401267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401267&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:113 > + auto width = style.logicalWidth(); > + > + switch (widthType) { > + case WidthType::Normal: > + width = style.logicalWidth(); Is it necessary to compute call style.logicalWidth() twice here?
zalan
Comment 9 2020-06-06 19:32:52 PDT
(In reply to Sam Weinig from comment #8) > Comment on attachment 401267 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401267&action=review > > > Source/WebCore/layout/FormattingContextGeometry.cpp:113 > > + auto width = style.logicalWidth(); > > + > > + switch (widthType) { > > + case WidthType::Normal: > > + width = style.logicalWidth(); > > Is it necessary to compute call style.logicalWidth() twice here? Haha, yeah absolutely not. Thanks.
Note You need to log in before you can comment on or make changes to this bug.