Bug 212863

Summary: [JSC] Shrink __DATA,(__data,__bss,__common) more
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212992    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch sam: review+

Yusuke Suzuki
Reported 2020-06-05 20:48:33 PDT
[JSC] Shrink __DATA,(__data,__bss,__common) more
Attachments
Patch (21.51 KB, patch)
2020-06-05 20:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (17.98 KB, patch)
2020-06-07 01:32 PDT, Yusuke Suzuki 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-06-05 20:50:38 PDT
Created attachment 401231 [details] Patch
EWS Watchlist
Comment 2 2020-06-05 20:51:30 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Yusuke Suzuki
Comment 3 2020-06-07 01:32:03 PDT
Created attachment 401287 [details] Patch
Mark Lam
Comment 4 2020-06-07 09:09:08 PDT
Comment on attachment 401287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401287&action=review Nice find. > Source/JavaScriptCore/heap/MarkedSpace.cpp:134 > + // We have an optimiation in MarkedSpace::optimalSizeFor() that assumes things about /optimiation/optimization/
Yusuke Suzuki
Comment 5 2020-06-09 02:19:39 PDT
Comment on attachment 401287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401287&action=review Thanks! >> Source/JavaScriptCore/heap/MarkedSpace.cpp:134 >> + // We have an optimiation in MarkedSpace::optimalSizeFor() that assumes things about > > /optimiation/optimization/ Fixed
Yusuke Suzuki
Comment 6 2020-06-09 02:20:50 PDT
Committed r262786: <https://trac.webkit.org/changeset/262786>
Radar WebKit Bug Importer
Comment 7 2020-06-09 02:21:18 PDT
<rdar://problem/64156273>
Yusuke Suzuki
Comment 8 2020-06-09 14:04:26 PDT
Let me try to use this bugzilla's patch for my webkitbot testing. So this will be re-opened, and closed.
Yusuke Suzuki
Comment 9 2020-06-09 14:05:39 PDT
Re-opened since this is blocked by bug 212992
Yusuke Suzuki
Comment 10 2020-06-09 14:06:18 PDT
(In reply to Yusuke Suzuki from comment #9) > Re-opened since this is blocked by bug 212992
Note You need to log in before you can comment on or make changes to this bug.