Bug 212855 – WebKitLegacy: Link to framework stubs for watchOS and tvOS

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

WebKitLegacy should link to framework stubs for watchOS and tvOS.

[Radar WebKit Bug Importer]

<rdar://problem/64049486>

[Jonathan Bedard]

Created attachment 401214 [details]
Patch

[Tim Horton]

Comment on attachment 401214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401214&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42
> +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
> +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)";

I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch" but also sdk=macosx* is the reason I removed all the SDK conditionals back in the day). Maybe it's OK?

[Jonathan Bedard]

(In reply to Tim Horton from comment #3)
> Comment on attachment 401214 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401214&action=review
> 
> > Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42
> > +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
> > +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)";
> 
> I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch"
> but also sdk=macosx* is the reason I removed all the SDK conditionals back
> in the day). Maybe it's OK?

I plan on look at getting Catalyst building next. It seems to me that Catalyst should be using Mac framework stubs, although that's something we'll need to decide.

[EWS]

Committed r262676: <https://trac.webkit.org/changeset/262676>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401214 [details].