Bug 212827

Summary: [IPC] Adopt enum class for PluginLoadClientPolicy
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Plug-insAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, useafterfree, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212758
https://bugs.webkit.org/show_bug.cgi?id=212846
Bug Depends on:    
Bug Blocks: 211988    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2020-06-05 08:43:28 PDT
Adopt enum class for PluginLoadClientPolicy. Also add EnumTraits< WebCore::PluginLoadClientPolicy > since this type is used via IPC, and replace uint8_t with more strongly typed WebCore::PluginLoadClientPolicy.
Attachments
Patch v1 (26.51 KB, patch)
2020-06-05 09:39 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (26.79 KB, patch)
2020-06-05 10:32 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-06-05 08:46:32 PDT
<rdar://problem/64030431>
David Kilzer (:ddkilzer)
Comment 2 2020-06-05 09:39:45 PDT
Created attachment 401163 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2020-06-05 09:47:19 PDT
Comment on attachment 401163 [details] Patch v1 Wee! Build failures.
David Kilzer (:ddkilzer)
Comment 4 2020-06-05 10:32:51 PDT
Created attachment 401172 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 5 2020-06-05 13:06:36 PDT
Comment on attachment 401172 [details] Patch v2 Adding cq+ since the Windows layout test failure and the api-ios test failure don't seem to be related to this patch.
EWS
Comment 6 2020-06-05 13:15:13 PDT
Committed r262648: <https://trac.webkit.org/changeset/262648> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401172 [details].
Note You need to log in before you can comment on or make changes to this bug.