Bug 212759 – Text manipulation: first and last unit in a paragraph should not contain only excluded tokens

• Component: HTML Editing
• Status: RESOLVED FIXED

[Sihui Liu]

...

[Sihui Liu]

Created attachment 401047 [details]
Patch

[Wenson Hsieh]

Comment on attachment 401047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401047&action=review

> Source/WebCore/ChangeLog:10
> +        tokens in a ManipulationUnit are excluded, it means the ManipulationUnit is exluced and should not be 

Nit - “exluced”

> Source/WebCore/editing/TextManipulationController.cpp:417
> +                Vector<ManipulationToken> tokens;
> +                tokens.append(ManipulationToken { m_tokenIdentifier.generate(), "[]", tokenInfo(content.node.get()), true });
> +                unitsInCurrentParagraph.append(ManipulationUnit { WTFMove(tokens), *contentNode });

Nit - you probably don’t need a local variable for `tokens`. But if you want to keep the local variable, you should use an initializer list when initializing `tokens`.

[Sihui Liu]

Created attachment 401120 [details]
Patch for landing

[EWS]

Committed r262601: <https://trac.webkit.org/changeset/262601>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401120 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64033285>