Bug 212726

Summary: Work around broken system version macro
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2020-06-03 21:39:28 PDT
Work around broken system version macro
Attachments
Patch (17.06 KB, patch)
2020-06-03 21:40 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (17.12 KB, patch)
2020-06-03 21:59 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (26.81 KB, patch)
2020-06-03 23:08 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-06-03 21:40:06 PDT
Created attachment 400994 [details] Patch
EWS Watchlist
Comment 2 2020-06-03 21:40:46 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Tim Horton
Comment 3 2020-06-03 21:59:52 PDT
Created attachment 400995 [details] Patch
Alexey Proskuryakov
Comment 4 2020-06-03 22:43:04 PDT
Isn’t there anything in Tools, especially TestWebKitAPI comes to mind.
Tim Horton
Comment 5 2020-06-03 23:06:57 PDT
Good point. This is what I get for searching with the workspace :)
Tim Horton
Comment 6 2020-06-03 23:08:49 PDT
Created attachment 401002 [details] Patch
EWS
Comment 7 2020-06-04 09:08:48 PDT
Committed r262542: <https://trac.webkit.org/changeset/262542> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401002 [details].
Radar WebKit Bug Importer
Comment 8 2020-06-04 09:09:23 PDT
<rdar://problem/63980810>
Note You need to log in before you can comment on or make changes to this bug.