Bug 212699

Summary: [iOS] Hide the PiP button in fullscreen mode if PiP is disabled in preferences
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2020-06-03 09:05:58 PDT
[iOS] Hide the PiP button in fullscreen mode if PiP is disabled in preferences
Attachments
Patch (3.44 KB, patch)
2020-06-03 09:10 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (2.17 KB, patch)
2020-06-03 09:29 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.17 KB, patch)
2020-06-03 09:49 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-06-03 09:07:38 PDT
<rdar://problem/60391437>
Jer Noble
Comment 2 2020-06-03 09:10:27 PDT
Created attachment 400924 [details] Patch
Eric Carlson
Comment 3 2020-06-03 09:13:55 PDT
Comment on attachment 400924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400924&action=review > Source/WebKit/ChangeLog:22 > +2020-05-29 Jer Noble <jer.noble@apple.com> > + > + [Cocoa] EME should return more helpful error code during key exchange > + https://bugs.webkit.org/show_bug.cgi?id=212535 > + > + Reviewed by NOBODY (OOPS!). > + Oops!
Jer Noble
Comment 4 2020-06-03 09:29:30 PDT
Created attachment 400929 [details] Patch for landing
Jer Noble
Comment 5 2020-06-03 09:49:11 PDT
Created attachment 400933 [details] Patch for landing
EWS
Comment 6 2020-06-03 12:45:59 PDT
Committed r262508: <https://trac.webkit.org/changeset/262508> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400933 [details].
Note You need to log in before you can comment on or make changes to this bug.