Bug 212687

Summary:

DFGSSAConversionPhase.cpp needs to #include OperandsInlines.h.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, ews-watchlist, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

212680

Attachments:

Description	Flags
test for Windows Bot.	none
test patch w/ non-unified build fixes.	none
test for Windows bot w/ non-unified fixes.	none
test for Windows bot w/ DFGSSAConversionPhase.cpp #include	none
test for Windows bot w/ DFGSSAConversionPhase.cpp #include.	none
proposed patch.	keith_miller: review+

Mark Lam

Reported 2020-06-02 23:02:58 PDT

...

Attachments
test for Windows Bot. (595 bytes, patch) 2020-06-02 23:10 PDT, Mark Lam	no flags	Details Formatted Diff Diff
test patch w/ non-unified build fixes. (41.43 KB, patch) 2020-06-03 00:41 PDT, Mark Lam	no flags	Details Formatted Diff Diff
test for Windows bot w/ non-unified fixes. (48.29 KB, patch) 2020-06-03 00:47 PDT, Mark Lam	no flags	Details Formatted Diff Diff
test for Windows bot w/ DFGSSAConversionPhase.cpp #include (35.05 KB, patch) 2020-06-03 10:51 PDT, Mark Lam	no flags	Details Formatted Diff Diff
test for Windows bot w/ DFGSSAConversionPhase.cpp #include. (35.05 KB, patch) 2020-06-03 10:54 PDT, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (1.79 KB, patch) 2020-06-03 12:48 PDT, Mark Lam	keith_miller: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2020-06-02 23:10:54 PDT

Created attachment 400901 [details] test for Windows Bot.

Mark Lam

Comment 2 2020-06-03 00:41:23 PDT

Created attachment 400904 [details] test patch w/ non-unified build fixes.

Mark Lam

Comment 3 2020-06-03 00:47:00 PDT

Created attachment 400905 [details] test for Windows bot w/ non-unified fixes.

Mark Lam

Comment 4 2020-06-03 10:51:20 PDT

Created attachment 400943 [details] test for Windows bot w/ DFGSSAConversionPhase.cpp #include

Mark Lam

Comment 5 2020-06-03 10:54:27 PDT

Created attachment 400944 [details] test for Windows bot w/ DFGSSAConversionPhase.cpp #include.

Mark Lam

Comment 6 2020-06-03 12:48:54 PDT

Created attachment 400959 [details] proposed patch.

Keith Miller

Comment 7 2020-06-03 12:50:54 PDT

Comment on attachment 400959 [details] proposed patch. r=me

Mark Lam

Comment 8 2020-06-03 12:58:58 PDT

Thanks for the review. Landed in r262510: <http://trac.webkit.org/r262510>.

Radar WebKit Bug Importer

Comment 9 2020-06-03 12:59:16 PDT

<rdar://problem/63940606>

Note You need to log in before you can comment on or make changes to this bug.