Bug 212631

Summary: UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2020-06-02 01:59:14 PDT
UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
Attachments
Patch (2.68 KB, patch)
2020-06-02 01:59 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-06-02 01:59:36 PDT
Created attachment 400798 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-06-02 01:59:58 PDT
<rdar://problem/63865676>
Anders Carlsson
Comment 3 2020-06-02 07:28:14 PDT
Comment on attachment 400798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400798&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:98 > + return Color(); Can probably just return { } here. > Source/WebCore/platform/graphics/mac/ColorMac.mm:108 > + return Color(); Same. > Source/WebCore/platform/ios/ColorIOS.mm:38 > + return Color(); Same.
Tim Horton
Comment 4 2020-06-02 10:10:37 PDT
True!
Tim Horton
Comment 5 2020-06-02 10:12:03 PDT
https://trac.webkit.org/changeset/262428/webkit
Note You need to log in before you can comment on or make changes to this bug.