Summary: | REGRESSION(r217572): run-webkit-tests should abort if the TCP ports for the servers are already in use. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | ap, cgarcia, dbates, ews-watchlist, glenn, gsnedders, jbedard, jonlee, lforschler, simon.fraser, slewis, youennf | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=182360 https://bugs.webkit.org/show_bug.cgi?id=172176 |
||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2020-06-01 18:30:19 PDT
Created attachment 400776 [details]
Patch
Comment on attachment 400776 [details]
Patch
I'm not against this, but I'm curious what people who make more use of these servers than myself things. Does Youenn have an opinion?
I sometimes have the HTTP servers up and running so that I can debug in a browser. I find it useful that WTR can run in parallel. But I can see why this could cause issues. @Carlos, can you detail a bit the problems you encountered? Another possibility is that we save a sort of status file (much like Postgres does) so we can keep track of our own web servers, but not generic ones running on the same ports. (In reply to youenn fablet from comment #3) > @Carlos, can you detail a bit the problems you encountered? We have some shared remote servers for building, developing and testing and I found random timeouts and failures when running WebKit layout tests on them. Investigating the issue, I found that it was because I was running the layout tests at the same time than other mate. Previously if this situation happened, run-webkit-tests aborted with a loud warning (so it was easy to spot the issue). (In reply to Carlos Alberto Lopez Perez from comment #5) > (In reply to youenn fablet from comment #3) > > @Carlos, can you detail a bit the problems you encountered? > > We have some shared remote servers for building, developing and testing and > I found random timeouts and failures when running WebKit layout tests on > them. Investigating the issue, I found that it was because I was running the > layout tests at the same time than other mate. > Previously if this situation happened, run-webkit-tests aborted with a loud > warning (so it was easy to spot the issue). I see, so multiple checkouts but a single server actually running. Would a console message warning stating that servers are already running be sufficient? (In reply to youenn fablet from comment #6) > (In reply to Carlos Alberto Lopez Perez from comment #5) > > (In reply to youenn fablet from comment #3) > > > @Carlos, can you detail a bit the problems you encountered? > > > > We have some shared remote servers for building, developing and testing and > > I found random timeouts and failures when running WebKit layout tests on > > them. Investigating the issue, I found that it was because I was running the > > layout tests at the same time than other mate. > > Previously if this situation happened, run-webkit-tests aborted with a loud > > warning (so it was easy to spot the issue). > > I see, so multiple checkouts but a single server actually running. > Would a console message warning stating that servers are already running be > sufficient? Yes, I guess it will be sufficient. |