Bug 212577

Summary: Rename Signal::BadAccess to Signal::AccessFault.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212575    
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-05-30 22:41:08 PDT
This is needed because GTK port's X11 has a #define for BadAccess (in include/X11/X.h): #define BadAccess 10 /* depending on context: - key/button already grabbed - attempt to free an illegal cmap entry - attempt to store into a read-only color map entry. - attempt to modify the access control list from other than the local host. */ As a result, this breaks the GTK build when wtf/Signals.h is #include'd.
Attachments
proposed patch. (6.91 KB, patch)
2020-05-30 22:47 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-05-30 22:47:43 PDT
Created attachment 400695 [details] proposed patch.
Yusuke Suzuki
Comment 2 2020-05-30 22:52:54 PDT
Comment on attachment 400695 [details] proposed patch. r=me
Mark Lam
Comment 3 2020-05-30 22:55:28 PDT
Thanks for the review. Landed in r262355: <http://trac.webkit.org/r262355>.
Radar WebKit Bug Importer
Comment 4 2020-05-30 22:56:18 PDT
<rdar://problem/63803124>
Note You need to log in before you can comment on or make changes to this bug.