Bug 212575

Summary: Change JSC::Config to use storage in WTF::Config instead of its own.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212577    
Bug Blocks:    
Attachments:
Description Flags
proposed patch.
none
proposed patch.
none
propose patch.
none
test wild guess that BadAccess is some #define in gtk/X11 code.
none
test wild guess that BadAccess is some #define in gtk/X11 code. none

Mark Lam
Reported 2020-05-30 16:02:17 PDT
Since Configs must be rounded up to CeilingOnPageSize, this will save us some memory since the contents of both Configs do not add up to CeilingOnPageSize.
Attachments
proposed patch. (10.06 KB, patch)
2020-05-30 16:33 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (9.13 KB, patch)
2020-05-30 17:06 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
propose patch. (9.13 KB, patch)
2020-05-30 17:17 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
test wild guess that BadAccess is some #define in gtk/X11 code. (9.13 KB, patch)
2020-05-30 21:12 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
test wild guess that BadAccess is some #define in gtk/X11 code. (13.59 KB, patch)
2020-05-30 21:39 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-30 16:02:52 PDT
<rdar://problem/63796584>
Mark Lam
Comment 2 2020-05-30 16:33:13 PDT
Created attachment 400682 [details] proposed patch.
Mark Lam
Comment 3 2020-05-30 17:06:55 PDT
Created attachment 400684 [details] proposed patch.
Mark Lam
Comment 4 2020-05-30 17:17:18 PDT
Created attachment 400685 [details] propose patch.
Mark Lam
Comment 5 2020-05-30 17:44:16 PDT
Comment on attachment 400685 [details] propose patch. I think this is ready for a review.
Yusuke Suzuki
Comment 6 2020-05-30 17:49:40 PDT
It seems that GTK bot is failing, can you take a look?
Mark Lam
Comment 7 2020-05-30 17:55:02 PDT
(In reply to Yusuke Suzuki from comment #6) > It seems that GTK bot is failing, can you take a look? I looked. That failure is very strange. I didn't touch that code in this patch. So, I'm not sure how it ever built before if it's not building now.
Mark Lam
Comment 8 2020-05-30 18:03:16 PDT
(In reply to Mark Lam from comment #7) > (In reply to Yusuke Suzuki from comment #6) > > It seems that GTK bot is failing, can you take a look? > > I looked. That failure is very strange. I didn't touch that code in this > patch. So, I'm not sure how it ever built before if it's not building now. I see what may be happening. JSCConfig.h now #include WTFConfig.h, and this somehow messes up GTK's build. Still investigating.
Mark Lam
Comment 9 2020-05-30 21:12:16 PDT
Created attachment 400691 [details] test wild guess that BadAccess is some #define in gtk/X11 code.
Mark Lam
Comment 10 2020-05-30 21:39:40 PDT
Created attachment 400693 [details] test wild guess that BadAccess is some #define in gtk/X11 code.
Mark Lam
Comment 11 2020-05-30 22:56:45 PDT
GTK build failure is due to https://bugs.webkit.org/show_bug.cgi?id=212577, which is now fixed.
Yusuke Suzuki
Comment 12 2020-05-30 23:08:15 PDT
Comment on attachment 400685 [details] propose patch. r=me
Mark Lam
Comment 13 2020-05-30 23:46:56 PDT
Comment on attachment 400685 [details] propose patch. Thanks for the review. Landing now.
EWS
Comment 14 2020-05-31 00:05:39 PDT
Committed r262356: <https://trac.webkit.org/changeset/262356> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400685 [details].
Note You need to log in before you can comment on or make changes to this bug.