Bug 212575

Summary:

Change JSC::Config to use storage in WTF::Config instead of its own.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

212577

Bug Blocks:

Attachments:

Description	Flags
proposed patch.	none
proposed patch.	none
propose patch.	none
test wild guess that BadAccess is some #define in gtk/X11 code.	none
test wild guess that BadAccess is some #define in gtk/X11 code.	none

Description Mark Lam 2020-05-30 16:02:17 PDT

Since Configs must be rounded up to CeilingOnPageSize, this will save us some memory since the contents of both Configs do not add up to CeilingOnPageSize.

Comment 1 Radar WebKit Bug Importer 2020-05-30 16:02:52 PDT

<rdar://problem/63796584>

Comment 2 Mark Lam 2020-05-30 16:33:13 PDT

Created attachment 400682 [details]
proposed patch.

Comment 3 Mark Lam 2020-05-30 17:06:55 PDT

Created attachment 400684 [details]
proposed patch.

Comment 4 Mark Lam 2020-05-30 17:17:18 PDT

Created attachment 400685 [details]
propose patch.

Comment 5 Mark Lam 2020-05-30 17:44:16 PDT

Comment on attachment 400685 [details]
propose patch.

I think this is ready for a review.

Comment 6 Yusuke Suzuki 2020-05-30 17:49:40 PDT

It seems that GTK bot is failing, can you take a look?

Comment 7 Mark Lam 2020-05-30 17:55:02 PDT

(In reply to Yusuke Suzuki from comment #6)
> It seems that GTK bot is failing, can you take a look?

I looked.  That failure is very strange.  I didn't touch that code in this patch.  So, I'm not sure how it ever built before if it's not building now.

Comment 8 Mark Lam 2020-05-30 18:03:16 PDT

(In reply to Mark Lam from comment #7)
> (In reply to Yusuke Suzuki from comment #6)
> > It seems that GTK bot is failing, can you take a look?
> 
> I looked.  That failure is very strange.  I didn't touch that code in this
> patch.  So, I'm not sure how it ever built before if it's not building now.

I see what may be happening.  JSCConfig.h now #include WTFConfig.h, and this somehow messes up GTK's build.  Still investigating.

Comment 9 Mark Lam 2020-05-30 21:12:16 PDT

Created attachment 400691 [details]
test wild guess that BadAccess is some #define in gtk/X11 code.

Comment 10 Mark Lam 2020-05-30 21:39:40 PDT

Created attachment 400693 [details]
test wild guess that BadAccess is some #define in gtk/X11 code.

Comment 11 Mark Lam 2020-05-30 22:56:45 PDT

GTK build failure is due to https://bugs.webkit.org/show_bug.cgi?id=212577, which is  now fixed.

Comment 12 Yusuke Suzuki 2020-05-30 23:08:15 PDT

Comment on attachment 400685 [details]
propose patch.

r=me

Comment 13 Mark Lam 2020-05-30 23:46:56 PDT

Comment on attachment 400685 [details]
propose patch.

Thanks for the review.  Landing now.

Comment 14 EWS 2020-05-31 00:05:39 PDT

Committed r262356: <https://trac.webkit.org/changeset/262356>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400685 [details].