Bug 212574

Summary: [GTK][WPE][EME] Update WPT and rebaseline
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, lmoura, philipj, sergio, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212586    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Charlie Turner
Reported 2020-05-30 13:52:53 PDT
[GTK][WPE][EME] Update WPT and rebaseline
Attachments
Patch (117.06 KB, patch)
2020-05-30 13:56 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (117.02 KB, patch)
2020-05-30 14:02 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (117.83 KB, patch)
2020-06-05 03:50 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (116.79 KB, patch)
2020-06-05 03:59 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (116.81 KB, patch)
2020-06-06 10:11 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2020-05-30 13:56:57 PDT
Created attachment 400677 [details] Patch
EWS Watchlist
Comment 2 2020-05-30 13:58:03 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Charlie Turner
Comment 3 2020-05-30 14:02:08 PDT
Created attachment 400678 [details] Patch I don't think I need to do anything to the WPT repo since I am only pulling from them (from a while ago now). I included the EME tests as a feature category of glib TestExpectations. As discussed offline I thought we agreed to organize the file by feature rather than test status
Lauro Moura
Comment 4 2020-05-31 21:07:31 PDT
(In reply to Charlie Turner from comment #3) > I included the EME tests as a feature > category of glib TestExpectations. As discussed offline I thought we agreed > to organize the file by feature rather than test status Yes, that is still the plan but I had not yet converted it (just submitted in bug212586).
Charlie Turner
Comment 5 2020-06-01 02:59:03 PDT
(In reply to Lauro Moura from comment #4) > (In reply to Charlie Turner from comment #3) > > I included the EME tests as a feature > > category of glib TestExpectations. As discussed offline I thought we agreed > > to organize the file by feature rather than test status > > Yes, that is still the plan but I had not yet converted it (just submitted > in bug212586). I will wait for that to land, thanks for letting me know.
Charlie Turner
Comment 6 2020-06-05 03:50:22 PDT
Created attachment 401138 [details] Patch
Charlie Turner
Comment 7 2020-06-05 03:59:21 PDT
Created attachment 401139 [details] Patch
EWS
Comment 8 2020-06-05 04:11:43 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Charlie Turner
Comment 9 2020-06-06 10:11:47 PDT
Created attachment 401266 [details] Patch Manually reset reviewer field. Need to figure out how to fix my workflow to avoid this nuisance
EWS
Comment 10 2020-06-06 10:49:07 PDT
Committed r262689: <https://trac.webkit.org/changeset/262689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401266 [details].
Note You need to log in before you can comment on or make changes to this bug.