Bug 212572

Summary: Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: UI EventsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, benjamin, cdumez, changseok, cmarcelo, dbates, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, kangil.han, koivisto, kondapallykalyan, luiz, pdr, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2020-05-30 12:36:50 PDT
Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling
Attachments
Patch (14.70 KB, patch)
2020-05-30 12:37 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-05-30 12:37:33 PDT
Created attachment 400675 [details] Patch
Andy Estes
Comment 2 2020-05-30 12:41:13 PDT
Comment on attachment 400675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400675&action=review > Source/WTF/wtf/PlatformEnable.h:491 > +#if !defined(ENABLE_TOUCH_ACTION_REGIONS) > +#define ENABLE_TOUCH_ACTION_REGIONS 0 > +#endif Not sure why we have to do this when the default is 0, because !ENABLE_TOUCH_ACTION_REGIONS and !defined(ENABLE_TOUCH_ACTION_REGIONS) is the same as far as the ENABLE() macro is concerned.
EWS
Comment 3 2020-06-01 12:38:40 PDT
Committed r262390: <https://trac.webkit.org/changeset/262390> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400675 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-01 12:39:16 PDT
<rdar://problem/63839368>
Note You need to log in before you can comment on or make changes to this bug.