Summary: | Tests expecting a crash should use a signal handler in the JSC CLI process | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, mcatanzaro, msaboff, saam, tpopela, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Keith Miller
2020-05-28 11:09:42 PDT
Created attachment 400484 [details]
Patch
Comment on attachment 400484 [details]
Patch
r=me
Created attachment 401795 [details]
Patch for landing
Tools/Scripts/svn-apply failed to apply attachment 401795 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 401803 [details]
Patch for landing
Committed r262991: <https://trac.webkit.org/changeset/262991> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401803 [details]. This broke stress/ensure-crash.js on Red Hat's internal CI: Running stress/ensure-crash.js.default stress/ensure-crash.js.default: ERROR: Unexpected exit code: 134 FAIL: stress/ensure-crash.js.default Running stress/ensure-crash.js.mini-mode stress/ensure-crash.js.mini-mode: ERROR: Unexpected exit code: 134 FAIL: stress/ensure-crash.js.mini-mode 134 - 128 = 6 = SIGABRT on Linux, so the test is failing with SIGABRT. (SIGILL = 4 so if it were to exit with SIGILL its exit status would be 132.) Skimming the commit, I don't immediately see what could be causing a SIGABRT, so I'll take a look later this week (assuming the issue is not immediately clear to you). I thought the most likely problem was that this change assumes HAVE(MACHINE_CONTEXT) is enabled, but looking in PlatformHave.h, that is not true on two of the four architectures we test (ppc64le and s390x). However, the test is failing in the same way on both x86_64 and aarch64, so that must not be the only problem here. I'll investigate more next week if the issue isn't immediately obvious to you.... This is cloop CI, so ENABLE(SIGNAL_BASED_VM_TRAPS) is disabled on all architectures because it depends on DFG and we are testing cloop. I don't know what VM traps is or if it's related, but I see it plays with signals and might possibly explain why the issue occurs on more architectures than I had expected, so I mention it. Created bug #213200. Let's see if I can reproduce locally.... |