Bug 212452

Summary:

Add output file specifications to "Copy Custom WebContent Resources to Framework Private Headers" build phase in WebKit/WebContent

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

Tools / Tests

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jberlin, sabouhallawa, simon.fraser, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Keith Rollin

Reported 2020-05-27 19:07:21 PDT

The "Copy Custom WebContent Resources to Framework Private Headers" build phase in the WebContent target of the WebKit project doesn't advertise the files that it produces. This has consequences on later build phases that consume those files. In particular, XCBuild is left not knowing where those files are coming from, and it fails saying that those files don't exist. Fix this by adding the output files to the "output files" section of the custom build phase.

Attachments
Patch (2.25 KB, patch) 2020-05-27 19:08 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-05-27 19:07:35 PDT

<rdar://problem/63700546>

Keith Rollin

Comment 2 2020-05-27 19:08:51 PDT

Created attachment 400420 [details] Patch

EWS

Comment 3 2020-05-27 22:53:21 PDT

Committed r262236: <https://trac.webkit.org/changeset/262236> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400420 [details].

Note You need to log in before you can comment on or make changes to this bug.