Bug 212425 – webkit-patch create-revert cannot handle reason string with Unicode characters (like smart quotes)

• Component: Tools / Tests
• Status: NEW

[Yusuke Suzuki]

If we pass non-ascii reason text to this command, it fails.

Traceback (most recent call last):
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py", line 62, in run
    message = self._message_for_revert(state["revision_list"], state["reason"], state["description_list"], reverted_bug_url_list, revert_bug_url)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py", line 48, in _message_for_revert
    message += "\"%s\"\n" % description_list[index]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 79: ordinal not in range(128)

[David Kilzer (:ddkilzer)]

See:  Bug 212422: REGRESSION(r260023): “Regression in ITP sparse plist decoding.”

[David Kilzer (:ddkilzer)]

Note that Slack appears to default to using smart quotes.

[Jonathan Bedard]

(In reply to David Kilzer (:ddkilzer) from comment #2)
> Note that Slack appears to default to using smart quotes.

We should fix this bug, but I also think that we should convert smart quotes to normal quotes.

[Radar WebKit Bug Importer]

<rdar://problem/64081137>