Bug 212418

Summary:

[Cocoa] Remove unconditional features from FeatureDefines.xcconfig, making sure they are covered in PlatformEnableCocoa.h

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, andersca, ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tsavell, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

212420, 212451, 212664

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Darin Adler 2020-05-27 10:41:19 PDT

Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h

Comment 1 Darin Adler 2020-05-27 10:45:00 PDT Comment hidden (obsolete)

Created attachment 400350 [details]
Patch

Comment 2 Darin Adler 2020-05-29 12:08:22 PDT Comment hidden (obsolete)

Created attachment 400605 [details]
Patch

Comment 3 Darin Adler 2020-05-29 12:18:29 PDT

After this, with a little more blood, sweat, and tears, we might be able to get rid of all 6 copies of the FeatureDefines.xcconfig file!

Comment 4 Darin Adler 2020-05-29 12:48:04 PDT Comment hidden (obsolete)

Committed r262311: <https://trac.webkit.org/changeset/262311>

Comment 5 Radar WebKit Bug Importer 2020-05-29 12:49:15 PDT

<rdar://problem/63769820>

Comment 6 Truitt Savell 2020-05-29 14:05:06 PDT Comment hidden (obsolete)

It looks like the changes in https://trac.webkit.org/changeset/262311/webkit

broke 14 layout tests:
http/wpt/css/css-images-4/conic-gradient-parsing.html [ Failure ]
  imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-image-source-computed.sub.html [ Failure ]
  imported/w3c/web-platform-tests/css/css-images/gradient/color-stops-parsing.html [ Failure ]
  fast/gradients/conic-center-outside-box.html [ ImageOnlyFailure ]
  fast/gradients/conic-extended-stops.html [ ImageOnlyFailure ]
  fast/gradients/conic-from-angle.html [ ImageOnlyFailure ]
  fast/gradients/conic-gradient-alpha.html [ ImageOnlyFailure ]
  fast/gradients/conic-gradient-extended-stops.html [ ImageOnlyFailure ]
  fast/gradients/conic-gradient.html [ ImageOnlyFailure ]
  fast/gradients/conic-off-center.html [ ImageOnlyFailure ]
  fast/gradients/conic-repeating-last-stop.html [ ImageOnlyFailure ]
  fast/gradients/conic-repeating.html [ ImageOnlyFailure ]
  fast/gradients/conic-two-hints.html [ ImageOnlyFailure ]
  fast/gradients/conic.html [ ImageOnlyFailure ]

Results:
https://build.webkit.org/results/Apple-Catalina-Release-WK1-Tests/r262311%20(6271)/results.html

Comment 7 Truitt Savell 2020-05-29 14:06:29 PDT Comment hidden (obsolete)

It appears that most of the Diffs show no image or missing parts of an image.

Comment 8 Darin Adler 2020-05-29 14:25:25 PDT Comment hidden (obsolete)

Tests should be fixed by https://trac.webkit.org/changeset/262318

Comment 9 Andy Estes 2020-06-04 12:12:12 PDT Comment hidden (obsolete)

Reopening because r262311 and r262318 were reverted in r262462: <https://trac.webkit.org/changeset/262462>.

Comment 10 Darin Adler 2020-07-04 10:03:56 PDT

Created attachment 403528 [details]
Patch

Comment 11 Darin Adler 2020-07-04 11:47:42 PDT

OK, this one is ready to go now. Looks like the prep work was successful, and all this removal worked!

Comment 12 Sam Weinig 2020-07-04 11:57:35 PDT

Comment on attachment 403528 [details]
Patch

Very nice!

Comment 13 EWS 2020-07-04 12:21:09 PDT

Committed r263942: <https://trac.webkit.org/changeset/263942>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403528 [details].