Bug 212390

Summary: [WebGPU] Update texture creation validation
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Myles C. Maxfield
Reported 2020-05-26 16:00:43 PDT
[WebGPU] Update texture creation validation according to the discussion at https://github.com/gpuweb/gpuweb/pull/799/files
Attachments
Patch (10.11 KB, patch)
2020-05-26 16:02 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-05-26 16:02:31 PDT
Created attachment 400283 [details] Patch
Justin Fan
Comment 2 2020-05-28 15:23:54 PDT
Comment on attachment 400283 [details] Patch Looks good! I don't have the power to r+, though.
Dean Jackson
Comment 3 2020-05-31 13:25:51 PDT
Comment on attachment 400283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400283&action=review > Source/WebCore/platform/graphics/gpu/GPUDevice.cpp:153 > if (descriptor.sampleCount != 1) { > + if (descriptor.sampleCount != 4) { > + m_errorScopes->generatePrefixedError("Texture sampleCount can only be 1 or 4."); > + return { }; > + } Could you move this to an early return? if (descriptor.sampleCount != 1 && descriptor.sampleCount != 4) { error and return } if (descriptor.sampleCount != 1) { // do the stuff for 4 }
Myles C. Maxfield
Comment 4 2020-06-01 23:06:33 PDT
Committed r262407: <https://trac.webkit.org/changeset/262407>
Radar WebKit Bug Importer
Comment 5 2020-06-01 23:07:15 PDT
<rdar://problem/63860411>
Note You need to log in before you can comment on or make changes to this bug.