| Summary: | SamplingProfiler::takeSample() should not assume that ENABLE(WEBASSEMBLY) means Wasm is enabled. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2020-05-26 12:17:41 PDT
Created attachment 400267 [details]
proposed patch.
Comment on attachment 400267 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=400267&action=review > Source/JavaScriptCore/ChangeLog:3 > + SamplingProfiler::takeSample() should assume that ENABLE(WEBASSEMBLY) means Wasm is enabled. should => should not Comment on attachment 400267 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=400267&action=review > Source/JavaScriptCore/runtime/SamplingProfiler.cpp:357 > + Lock unusedLock; > + auto wasmCalleesLocker = holdLock(Wasm::isSupported() ? Wasm::CalleeRegistry::singleton().getLock() : unusedLock); why not just use Optional<LockHolder>? Seems cleaner than this unusedLock approach Created attachment 400270 [details]
proposed patch.
Committed r262161: <https://trac.webkit.org/changeset/262161> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400270 [details]. |