Bug 212355

Summary: [css-flexbox] Tables as flex items should obey the flex container sizing
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch rego: review+

Sergio Villar Senin
Reported 2020-05-25 09:22:46 PDT
[css-flexbox] Tables as flex items should obey the flex container sizing
Attachments
Patch (4.02 KB, patch)
2020-05-25 09:41 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (8.10 KB, patch)
2020-05-25 12:24 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2020-05-25 12:51 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (13.17 KB, patch)
2020-05-26 03:59 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (13.00 KB, patch)
2020-05-26 04:12 PDT, Sergio Villar Senin 		rego: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-05-25 09:41:32 PDT
Created attachment 400206 [details] Patch
Sergio Villar Senin
Comment 2 2020-05-25 12:24:58 PDT
Created attachment 400213 [details] Patch Added another test that passes now
Sergio Villar Senin
Comment 3 2020-05-25 12:51:50 PDT
Created attachment 400217 [details] Patch Fixed duplicated ChangeLog
Sergio Villar Senin
Comment 4 2020-05-26 03:59:26 PDT
Created attachment 400237 [details] Patch New expectations
Sergio Villar Senin
Comment 5 2020-05-26 04:12:51 PDT
Created attachment 400238 [details] Patch Rebased. Fixed conflicts
Sergio Villar Senin
Comment 6 2020-05-26 06:18:53 PDT
Zalan, Darin could you take a look? Thanks!
Manuel Rego Casasnovas
Comment 7 2020-06-01 07:42:44 PDT
Comment on attachment 400238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400238&action=review The patch looks good to me, just a minor comment inline. > Source/WebCore/rendering/RenderTable.cpp:284 > + // is how flexible containers flex or stretch us. Nit: s/flexible containers/flex container/ (that's the term on the spec so I guess it's better to use it https://drafts.csswg.org/css-flexbox/#flex-containers).
Sergio Villar Senin
Comment 8 2020-06-01 08:18:38 PDT
Committed r262378: <https://trac.webkit.org/changeset/262378>
Radar WebKit Bug Importer
Comment 9 2020-06-01 08:19:15 PDT
<rdar://problem/63829730>
Note You need to log in before you can comment on or make changes to this bug.