Bug 212319

Summary: [GTK4] Implement HTTP auth dialog
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gustavo, svillar
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212318    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch svillar: review+

Description Carlos Garcia Campos 2020-05-24 05:46:12 PDT
.
Comment 1 Carlos Garcia Campos 2020-05-27 04:57:45 PDT
Created attachment 400321 [details]
Patch
Comment 2 EWS Watchlist 2020-05-27 04:58:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Sergio Villar Senin 2020-05-28 06:29:10 PDT
Comment on attachment 400321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400321&action=review

Awesome!

> Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:145
>      gtk_widget_set_can_default(button, TRUE);

Isn't there an alternative for this on GTK4?
Comment 4 Carlos Garcia Campos 2020-05-28 06:56:40 PDT
(In reply to Sergio Villar Senin from comment #3)
> Comment on attachment 400321 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400321&action=review
> 
> Awesome!

Thanks for the review!

> > Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:145
> >      gtk_widget_set_can_default(button, TRUE);
> 
> Isn't there an alternative for this on GTK4?

No, can-default property was removed because it's no longer needed.
Comment 5 Carlos Garcia Campos 2020-05-29 02:47:23 PDT
Committed r262287: <https://trac.webkit.org/changeset/262287>