Bug 212289 – Do not send a second sync request for positition information to the web process if we have not recieved information since the previous sync request.

• Component: New Bugs
• Status: RESOLVED FIXED

[Megan Gardner]

Do not send a second sync request for positition information to the web process if we have not recieved information since the previous sync request.

[Megan Gardner]

Created attachment 400090 [details]
Patch

[Megan Gardner]

<rdar://problem/58494578>

[Megan Gardner]

Created attachment 400382 [details]
Patch

[Tim Horton]

Comment on attachment 400382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400382&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2245
> +    if (!_isWaitingOnPositionInformation) {

I would flip this around into an early return (don't wait if we're already waiting)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2253
> +    return _isWaitingOnPositionInformation;

Why do we return YES (that we have valid state) in the case where we're already waiting??

[Megan Gardner]

Created attachment 400401 [details]
Patch

[Tim Horton]

Comment on attachment 400401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400401&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2245
> +    if (_isWaitingOnPositionInformation)

I think this can just check _outstandingPositionInformationRequest, no need for a new bool, right?

[Megan Gardner]

Created attachment 400493 [details]
Patch for landing

[Megan Gardner]

I know I looked at using that bool, but concluded that it would not be enough information.

[Megan Gardner]

Oh, right because it will be true after we ask for position information, thus we will never attempt a waitForAndDispatchImmediately, which is not what we want.

[EWS]

Committed r262255: <https://trac.webkit.org/changeset/262255>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400493 [details].