Bug 212267

Summary:	[css-grid] imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-self-baseline-001.html asserts on Debug
Product:	WebKit	Reporter:	Carlos Alberto Lopez Perez <clopez>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	clopez, Hironori.Fujii, jfernandez, obrufau, rego, svillar
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=212246

Carlos Alberto Lopez Perez

Reported 2020-05-22 10:27:05 PDT

The test imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-self-baseline-001.html asserts on Debug: From: https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r262056%20(4447)/results.html ASSERTION FAILED: rangesIntersect(m_renderer->logicalTopForFloat(floatingObject), m_renderer->logicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ./rendering/FloatingObjects.cpp(470) : void WebCore::ComputeFloatOffsetAdapter<WebCore::FloatingObject::FloatLeft>::collectIfNeeded(const WebCore::ComputeFloatOffsetAdapter::IntervalType &) [FloatTypeValue = WebCore::FloatingObject::FloatLeft] 1 0x6d59aa979 WTFCrash 2 0x6b800318b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x6bc050ea7 WebCore::ComputeFloatOffsetAdapter<(WebCore::FloatingObject::Type)1>::collectIfNeeded(WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*> const&) 4 0x6bc05185d void WebCore::PODIntervalTree<WebCore::LayoutUnit, WebCore::FloatingObject*>::searchForOverlapsFrom<WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1> >(WebCore::PODRedBlackTree<WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*>, WebCore::PODIntervalNodeUpdater>::Node*, WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1>&) const 5 0x6bc051840 void WebCore::PODIntervalTree<WebCore::LayoutUnit, WebCore::FloatingObject*>::searchForOverlapsFrom<WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1> >(WebCore::PODRedBlackTree<WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*>, WebCore::PODIntervalNodeUpdater>::Node*, WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1>&) const 6 0x6bc051840 void WebCore::PODIntervalTree<WebCore::LayoutUnit, WebCore::FloatingObject*>::searchForOverlapsFrom<WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1> >(WebCore::PODRedBlackTree<WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*>, WebCore::PODIntervalNodeUpdater>::Node*, WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1>&) const 7 0x6bc0518b1 void WebCore::PODIntervalTree<WebCore::LayoutUnit, WebCore::FloatingObject*>::searchForOverlapsFrom<WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1> >(WebCore::PODRedBlackTree<WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*>, WebCore::PODIntervalNodeUpdater>::Node*, WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1>&) const 8 0x6bc0518b1 void WebCore::PODIntervalTree<WebCore::LayoutUnit, WebCore::FloatingObject*>::searchForOverlapsFrom<WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1> >(WebCore::PODRedBlackTree<WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*>, WebCore::PODIntervalNodeUpdater>::Node*, WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1>&) const 9 0x6bc03d793 void WebCore::PODIntervalTree<WebCore::LayoutUnit, WebCore::FloatingObject*>::allOverlapsWithAdapter<WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1> >(WebCore::ComputeFloatOffsetForLineLayoutAdapter<(WebCore::FloatingObject::Type)1>&) const 10 0x6bc03d6f4 WebCore::FloatingObjects::logicalLeftOffset(WebCore::LayoutUnit, WebCore::LayoutUnit, WebCore::LayoutUnit) 11 0x6bc0f95e5 WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine(WebCore::LayoutUnit, WebCore::LayoutUnit, WebCore::LayoutUnit) const 12 0x6bc0239d4 WebCore::RenderBlock::logicalLeftOffsetForLine(WebCore::LayoutUnit, WebCore::LayoutUnit, bool, WebCore::LayoutUnit) const 13 0x6bc00cf61 WebCore::RenderBlock::logicalLeftOffsetForLine(WebCore::LayoutUnit, WebCore::IndentTextOrNot, WebCore::LayoutUnit) const 14 0x6bc3a3291 WebCore::RootInlineBox::selectionTop(WebCore::RootInlineBox::ForHitTesting) const 15 0x6bc281b48 WebCore::RenderLineBoxList::lineIntersectsDirtyRect(WebCore::RenderBoxModelObject*, WebCore::InlineFlowBox*, WebCore::PaintInfo const&, WebCore::LayoutPoint const&) const 16 0x6bc28209b WebCore::RenderLineBoxList::paint(WebCore::RenderBoxModelObject*, WebCore::PaintInfo&, WebCore::LayoutPoint const&) const 17 0x6bc0fdfc1 WebCore::RenderBlockFlow::paintInlineChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 18 0x6bc0d2a0e WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 19 0x6bc0d3a70 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 20 0x6bc0d2303 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 21 0x6bc0d2fac WebCore::RenderBlock::paintChild(WebCore::RenderBox&, WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool, WebCore::RenderBlock::PaintBlockType) 22 0x6bc0d2bc1 WebCore::RenderBlock::paintChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&, WebCore::PaintInfo&, bool) 23 0x6bc0d2b0b WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 24 0x6bc0d3a70 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 25 0x6bc0d2303 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 26 0x6bc2481e0 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 27 0x6bc245bd8 WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 28 0x6bc241918 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 29 0x6bc240a64 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 30 0x6bc23fa1b WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 31 0x6bc23ecab WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) LEAK: 1 WebPageProxy On release it fails, see bug 212246

Attachments
Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2020-05-22 10:32:19 PDT

Skipped in r262062

Fujii Hironori

Comment 2 2022-12-22 13:44:12 PST

255455@main unskipped it. No crash has been observed so far. https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Falignment%2Fgrid-item-self-baseline-001.html It works now. And, I think the fundamental problem was fixed by bug#249571.

Note You need to log in before you can comment on or make changes to this bug.