Bug 212256

Summary: [GTK] jhbuild is broken with GCC 10.0
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebKitGTKAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bugs-noreply, calvaris, clopez, ews-watchlist, ltilve
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

ChangSeok Oh
Reported 2020-05-22 02:07:54 PDT
GCC 10 has -fno-common as default. It causes many multiple definition issues to build dependencies in jhbuild. I know we have moved to flatpak sdk but there may be someone who needs a fix for the issue like me.
Attachments
Patch (13.98 KB, patch)
2020-05-22 07:39 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2020-05-22 07:39:40 PDT
Created attachment 400045 [details] Patch
ChangSeok Oh
Comment 2 2020-05-22 10:33:24 PDT
Comment on attachment 400045 [details] Patch Thanks for your review!
EWS
Comment 3 2020-05-22 10:35:47 PDT
Committed r262063: <https://trac.webkit.org/changeset/262063> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400045 [details].
Note You need to log in before you can comment on or make changes to this bug.