Summary: | [WK2] WebKit abandons compiled sandbox profiles | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, benjamin, cmarcelo, ews-watchlist, ggaren, jbedard, mitz, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2020-05-20 16:32:45 PDT
Created attachment 399913 [details]
Patch
Comment on attachment 399913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399913&action=review > Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:259 > + // We save the profiles in the user tempory directory so that they get cleaned after on reboot "after on" => "on" Comment on attachment 399913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399913&action=review > Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:260 > + // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change "in 3 days" => "for 3 days" Comment on attachment 399913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399913&action=review >> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:260 >> + // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change > > "in 3 days" => "for 3 days" actually, I'm not sure which is more grammatically correct. I'll leave it up to you Comment on attachment 399913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399913&action=review >> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:259 >> + // We save the profiles in the user tempory directory so that they get cleaned after on reboot > > "after on" => "on" Will fix. >>> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:260 >>> + // or if they are not accessed in 3 days. This avoids accumulating profiles whenever we change >> >> "in 3 days" => "for 3 days" > > actually, I'm not sure which is more grammatically correct. I'll leave it up to you I copied from the official documentation which says "if they are not accessed in 3 days". Created attachment 399956 [details]
Patch
Committed r262004: <https://trac.webkit.org/changeset/262004> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399956 [details]. Comment on attachment 399956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399956&action=review > Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:264 > WTFLogAlways("%s: Could not retrieve user cache directory path: %s\n", getprogname(), strerror(errno)); Should probably change this from “cache” to “temporary”. (In reply to mitz from comment #9) > Comment on attachment 399956 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399956&action=review > > > Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:264 > > WTFLogAlways("%s: Could not retrieve user cache directory path: %s\n", getprogname(), strerror(errno)); > > Should probably change this from “cache” to “temporary”. Fixed in <https://trac.webkit.org/changeset/262005>, thanks. Reverted r262004 for reason: Revert r262004 as it is not OK to have a data vault in /var/folders/zy/g91x07sn08bgjkm8d_pg0vfc0000gn/T/ <rdar://problem/64540215> Committed r263705: <https://trac.webkit.org/changeset/263705> Created attachment 405292 [details]
Patch
Pull request: https://github.com/WebKit/WebKit/pull/24861 Committed 275108@main (2dfb4e9da6fd): <https://commits.webkit.org/275108@main> Reviewed commits have been landed. Closing PR #24861 and removing active labels. |