Bug 212160

Summary: [Apple Pay] Add new ApplePayInstallmentConfiguration members
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, esprehn+autocc, ews-watchlist, kondapallykalyan, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2020-05-20 11:59:47 PDT
[Apple Pay] Add new ApplePayInstallmentConfiguration members
Attachments
Patch (67.30 KB, patch)
2020-05-21 20:48 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (68.18 KB, patch)
2020-05-21 20:58 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2020-05-20 12:00:02 PDT
rdar://problem/60703650
Andy Estes
Comment 2 2020-05-21 20:48:15 PDT Comment hidden (obsolete)
Andy Estes
Comment 3 2020-05-21 20:58:42 PDT
Created attachment 400022 [details] Patch
Alex Christensen
Comment 4 2020-05-22 11:13:14 PDT
Comment on attachment 400022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400022&action=review > Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm:217 > + applicationMetadataDictionary = dynamic_objc_cast<NSDictionary>([NSJSONSerialization JSONObjectWithData:applicationMetadata options:0 error:nil]); Maybe we should pass an NSError** and return an exception here?
Andy Estes
Comment 5 2020-05-22 11:58:41 PDT
Comment on attachment 400022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400022&action=review >> Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm:217 >> + applicationMetadataDictionary = dynamic_objc_cast<NSDictionary>([NSJSONSerialization JSONObjectWithData:applicationMetadata options:0 error:nil]); > > Maybe we should pass an NSError** and return an exception here? -JSONObjectWithData:options:error: returns nil when an error occurs, so we will already return an exception in that case (as well as when the call succeeds but the JSON root value isn’t an object). Passing an NSError would let us include more diagnostic information in the Exception message, but I’m not sure we want to expose Foundation's error messages on the web.
EWS
Comment 6 2020-05-22 13:10:05 PDT
Committed r262069: <https://trac.webkit.org/changeset/262069> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400022 [details].
Andy Estes
Comment 7 2020-05-22 13:53:35 PDT
Fixed the build in r262072: <https://trac.webkit.org/changeset/262072>
Note You need to log in before you can comment on or make changes to this bug.