| Summary: | Checkpoint inlined call return handler needs an exception check when dispatching | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2020-05-19 13:24:33 PDT
Created attachment 399765 [details]
Patch
Comment on attachment 399765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399765&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:2093 > + if (scope.exception()) > + return encodeResult(returnToThrow(scope.vm()), nullptr); > + Can we insert exception check just after the operation which throws an exception? Maybe, handleIteratorNextCheckpoint? (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 399765 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399765&action=review > > > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:2093 > > + if (scope.exception()) > > + return encodeResult(returnToThrow(scope.vm()), nullptr); > > + > > Can we insert exception check just after the operation which throws an > exception? Maybe, handleIteratorNextCheckpoint? No, because the LLInt code we're returning to dispatches to whatever pc we return. It's easier to handle it all here. This also means that other new bytecodes "just work". Comment on attachment 399765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399765&action=review >>> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:2093 >>> + >> >> Can we insert exception check just after the operation which throws an exception? Maybe, handleIteratorNextCheckpoint? > > No, because the LLInt code we're returning to dispatches to whatever pc we return. It's easier to handle it all here. This also means that other new bytecodes "just work". OK, make sense. Committed r262064: <https://trac.webkit.org/changeset/262064> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399765 [details]. |