Bug 212084

Summary: Remove unnecessary debug logging from release builds.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2020-05-19 09:35:59 PDT
...
Attachments
proposed patch. (1.80 KB, patch)
2020-05-19 09:51 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-19 09:36:24 PDT
<rdar://problem/63398704>
Mark Lam
Comment 2 2020-05-19 09:51:12 PDT
Created attachment 399743 [details] proposed patch.
EWS
Comment 3 2020-05-19 10:53:56 PDT
Committed r261870: <https://trac.webkit.org/changeset/261870> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399743 [details].
Darin Adler
Comment 4 2020-05-19 10:57:03 PDT
Comment on attachment 399743 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=399743&action=review > Source/WTF/wtf/PtrTag.h:115 > #if ASSERT_ENABLED > constexpr bool enablePtrTagDebugAssert = true; > +#define REPORT_BAD_TAG(success, ptr, expectedTag) do { \ > + if (UNLIKELY(!success)) \ > + reportBadTag(reinterpret_cast<const void*>(ptr), expectedTag); \ > + } while (false) > #else > constexpr bool enablePtrTagDebugAssert = false; > +#define REPORT_BAD_TAG(success, ptr, expectedTag) > #endif I like this, but I would like to point out that in this case, this could have been an inline function rather than a macro; an empty inline function would neatly compile down to nothing.
Note You need to log in before you can comment on or make changes to this bug.