Summary: | [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2020-05-19 07:17:35 PDT
Created attachment 399732 [details]
Patch
Comment on attachment 399732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399732&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83 > - // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed. > -#if PLATFORM(MAC) > - return kCVPixelFormatType_420YpCbCr8Planar; > -#else > return preferedPixelBufferFormat(); > -#endif We should make this conditional on the build target since the fix is unlikely to be back ported. Maybe define something like HAVE_DISPLAY_LAYER_PLANAR_SUPPORT? (In reply to Eric Carlson from comment #2) > Comment on attachment 399732 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399732&action=review > > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83 > > - // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed. > > -#if PLATFORM(MAC) > > - return kCVPixelFormatType_420YpCbCr8Planar; > > -#else > > return preferedPixelBufferFormat(); > > -#endif > > We should make this conditional on the build target since the fix is > unlikely to be back ported. Maybe define something like > HAVE_DISPLAY_LAYER_PLANAR_SUPPORT? Oh right, will do! Created attachment 399823 [details]
Patch
Committed r261915: <https://trac.webkit.org/changeset/261915> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399823 [details]. |